Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constant time compare function to compare admin_password and api_key #527

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Use constant time compare function to compare admin_password and api_key #527

merged 2 commits into from
Jul 19, 2022

Conversation

j178
Copy link
Contributor

@j178 j178 commented Jul 19, 2022

Proposed changes

Add SecureCompare and SecureCompareString function to compare arrays/strings in constant time, avoiding timing side channel attack.

@FZambia
Copy link
Member

FZambia commented Jul 19, 2022

Thanks! Could you please add a couple of tests for SecureCompare and SecureCompareString?

@FZambia
Copy link
Member

FZambia commented Jul 19, 2022

Will add tests myself, want to merge this ASAP due to v4 release routine.

@FZambia FZambia merged commit c60a31a into centrifugal:master Jul 19, 2022
@FZambia
Copy link
Member

FZambia commented Jul 19, 2022

@j178 added some tests in 6037f6b - many thanks for contributing :)

@j178 j178 deleted the constant-time branch July 19, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j178 @FZambia