feat!: Multiple indexes per IndexWrapper #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
breaking
proto breaking
5 tasks
rootulp
approved these changes
Dec 23, 2022
cmwaters
approved these changes
Jan 2, 2023
evan-forbes
added a commit
to celestiaorg/celestia-app
that referenced
this pull request
Jan 16, 2023
## Overview This PR implements the ability to add an arbitrary number of blobs to a single PFB. Leaving as a draft until we merge the blocking [PR](celestiaorg/celestia-core#922) in core, and probably tidy up a bit, rebase, or add a few more unit tests. In part thanks to us planning ahead earlier this year, there's actually not that many required changes to get multiple blobs per PFB. Mostly just adding tests, using a **new mechanism to calculate the share commitments**, making a few things a slice instead of a single thing, and minor adjustments to make square estimation/square layout work with multiple blobs. closes #388 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords Co-authored-by: Rootul P <rootulp@gmail.com>
evan-forbes
added a commit
that referenced
this pull request
Jun 9, 2023
* feat! add support for multiple indexes in the index wrapper * fix: tests
cmwaters
pushed a commit
to celestiaorg/go-square
that referenced
this pull request
Dec 14, 2023
## Overview This PR implements the ability to add an arbitrary number of blobs to a single PFB. Leaving as a draft until we merge the blocking [PR](celestiaorg/celestia-core#922) in core, and probably tidy up a bit, rebase, or add a few more unit tests. In part thanks to us planning ahead earlier this year, there's actually not that many required changes to get multiple blobs per PFB. Mostly just adding tests, using a **new mechanism to calculate the share commitments**, making a few things a slice instead of a single thing, and minor adjustments to make square estimation/square layout work with multiple blobs. closes #388 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords Co-authored-by: Rootul P <rootulp@gmail.com>
0xchainlover
pushed a commit
to celestia-org/celestia-app
that referenced
this pull request
Aug 1, 2024
## Overview This PR implements the ability to add an arbitrary number of blobs to a single PFB. Leaving as a draft until we merge the blocking [PR](celestiaorg/celestia-core#922) in core, and probably tidy up a bit, rebase, or add a few more unit tests. In part thanks to us planning ahead earlier this year, there's actually not that many required changes to get multiple blobs per PFB. Mostly just adding tests, using a **new mechanism to calculate the share commitments**, making a few things a slice instead of a single thing, and minor adjustments to make square estimation/square layout work with multiple blobs. closes #388 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in order to have multiple blobs per PFB, we need to have multiple indexes as well. This PR adds those.
part of celestiaorg/celestia-app#890
blocking celestiaorg/celestia-app#1154