Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Unit 3.9 from CI #2046

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Jul 1, 2024

For some reason, unit tests for python 3.9 are hanging when running via GitHub Actions.
Locally, it passes successfully:

  3.8-unit: OK (63.03=setup[21.26]+cmd[41.77] seconds)
  3.9-unit: OK (61.05=setup[20.77]+cmd[40.28] seconds)
  3.10-unit: OK (61.68=setup[20.60]+cmd[41.08] seconds)
  3.11-unit: OK (62.84=setup[20.64]+cmd[42.20] seconds)
  3.12-unit: OK (62.81=setup[22.25]+cmd[40.56] seconds)

There wasn’t any PR that made changes that should break 3.9-unit tests but at this moment this is blocking from the rest of the CI to run and from validating further changes.

This is not ideal and should be reverted as soon as possible, but for now I want to skip 3.9 to allow the rest of the CI to run.

It is less probable that something that passes 3.8-unit will not also pass 3.9-unit in case it will be introduced during this time window, so it is not as risky as it looks but will bring out the benefit of being able to continue working on Kombu.

Apart from that, Python 3.9 tests will run as part of the integration tests so this will also reduce the risk of accepting this temporary CI change for now.

@Nusnus Nusnus marked this pull request as ready for review July 1, 2024 14:04
@Nusnus
Copy link
Member Author

Nusnus commented Jul 1, 2024

@auvipy FYI

@Nusnus Nusnus merged commit be057b0 into celery:main Jul 1, 2024
4 checks passed
@Nusnus Nusnus deleted the disable_unit39 branch July 1, 2024 14:12
Nusnus added a commit to Katz-Consulting-Group/kombu that referenced this pull request Jul 1, 2024
Nusnus added a commit that referenced this pull request Jul 1, 2024
Nusnus added a commit to Katz-Consulting-Group/kombu that referenced this pull request Jul 9, 2024
Nusnus added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant