Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core - Change Cef.IsInitialized from bool to bool? #4869

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Core - Change Cef.IsInitialized from bool to bool? #4869

merged 2 commits into from
Aug 14, 2024

Conversation

amaitland
Copy link
Member

Fixes:
#4867

Summary:
Change to nullable bool

Changes: [specify the structures changed]

  • change type
  • Throw exception if false

How Has This Been Tested?
Needs more testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@amaitland amaitland linked an issue Jul 6, 2024 that may be closed by this pull request
Change Cef.IsInitialized from bool to bool? #4867
Closed
@AppVeyorBot
Copy link

✅ Build CefSharp 126.2.70-CI5031 completed (commit 49b0d89047 by @amaitland)

@amaitland amaitland marked this pull request as ready for review August 14, 2024 07:18
@amaitland amaitland added this to the 127.3.x milestone Aug 14, 2024
@amaitland
Copy link
Member Author

I've asked https://www.magpcss.org/ceforum/viewtopic.php?f=6&t=19918 to see if it's possible to call CefInitialize twice if the first time fails due to singleton.

Assuming the answer will be no. If it's yes then we can change some of the checks later.

@amaitland amaitland merged commit 57f8cd3 into master Aug 14, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
127.3.x
Development

Successfully merging this pull request may close these issues.

Change Cef.IsInitialized from bool to bool?
2 participants
@amaitland @AppVeyorBot