Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavascriptBinding - Add JavascriptBindingSettings.JavascriptBindingApiEnabled property #3571

Merged

Conversation

amaitland
Copy link
Member

Summary:
The Javascript methods that CefSharp provides in relation to JavaScript Binding are
created using a Global (window) Object. Settings this property allows you to disable
the creation of this object. Features like EvaluateScriptAsPromiseAsync that rely on
the creation of this object will no longer function.

Changes:

  • Add JavascriptBindingSettings.JavascriptBindingApiEnabled property
  • Added test cases

How Has This Been Tested?

  • Unit Tests included

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

…iEnabled property

- The Javascript methods that CefSharp provides in relation to JavaScript Binding are
  created using a Global (window) Object. Settings this property allows you to disable
  the creation of this object. Features like EvaluateScriptAsPromiseAsync that rely on
  the creation of this object will no longer function.
@amaitland amaitland added this to the 91.1.x milestone May 19, 2021
@AppVeyorBot
Copy link

@amaitland amaitland merged commit 0386220 into cefsharp:master Jun 4, 2021
amaitland added a commit that referenced this pull request Jun 4, 2021
…iEnabled property (#3571)

- The Javascript methods that CefSharp provides in relation to JavaScript Binding are
  created using a Global (window) Object. Settings this property allows you to disable
  the creation of this object. Features like EvaluateScriptAsPromiseAsync that rely on
  the creation of this object will no longer function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants