WinForms - Add LifeSpanHandler implementation capable of hosting popups as Tabs/Controls #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example of the new API: browser.LifeSpanHandler = CefSharp.WinForms.Handler.LifeSpanHandler
.Create()
.OnPopupCreated((ctrl, targetUrl) =>
{
//Add popup to new parent control e.g. Tab
parent.Controls.Add(ctrl);
})
.OnPopupDestroyed((ctrl, popupBrowser) =>
{
//If browser is disposed or the handle has been released then we don't
//need to remove the tab (likely removed from menu)
if (!ctrl.IsDisposed && ctrl.IsHandleCreated)
{
parent.Controls.Remove(ctrl);
}
}).Build(); |
|
✅ Build CefSharp 90.5.30-CI4020 completed (commit 68d3964199 by @amaitland) |
campersau
reviewed
Apr 29, 2021
|
✅ Build CefSharp 90.5.30-CI4022 completed (commit f88dfa6395 by @amaitland) |
amaitland
force-pushed
the
winforms/popuplifespanhandler
branch
from
6986557 to
4a331bc
Compare
|
✅ Build CefSharp 91.1.10-CI4024 completed (commit 604c6193eb by @amaitland) |
|
✅ Build CefSharp 91.1.10-CI4025 completed (commit 4947487651 by @amaitland) |
|
Consider switching from Action to strongly typed delegates. Change the fluent method names. |
…ps as Tabs/Child controls in WinForms - Update Example - Remove PopupAsChildHelper and example LifeSpanHandler - Examples always opens popups as tabs now.
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
- Rename OnPopupCreated to RegisterPopupCreated - Rename OnPopupDestroyed to RegisterPopupDestroyed - Improve xml doc and comments
- Make ParentFormMessageInterceptor public - Make ChromiumHostControl public, move into CefSharp.WinForms.Host namespace Rather than having the class in the CefSharp.WinForms namespace and potentially confuse users, move into it's own namespace.
- Code cleanup - Improve comments
amaitland
force-pushed
the
winforms/popuplifespanhandler
branch
from
676386e to
e82331f
Compare
amaitland
added a commit
that referenced
this pull request
Jun 4, 2021
…ps as Tabs/Controls (#3529) * WinForms - Add LifeSpanHandler implementation capable of hosting popups as Tabs/Child controls in WinForms - Update Example - Remove PopupAsChildHelper and example LifeSpanHandler - Examples always opens popups as tabs now. - Improve xml doc and comments - Make ParentFormMessageInterceptor public - Make ChromiumHostControl public, move into CefSharp.WinForms.Host namespace Rather than having the class in the CefSharp.WinForms namespace and potentially confuse users, move into it's own namespace. - Clarify ShowDevToolsDocked needs to be used with the new WinForms lifespan handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Opening popups as Tabs is a fairly common scenario and requires extra plumbing currently.
This adds a LifeSpanHandler capable of hosting popups as Tabs/Sub Controls.
Changes:
How Has This Been Tested?
Types of changes
Checklist: