Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement - Add DevToolsClient #3229

Merged
merged 25 commits into from
Sep 21, 2020
Merged

Enhancement - Add DevToolsClient #3229

merged 25 commits into from
Sep 21, 2020

Conversation

amaitland
Copy link
Member

@amaitland amaitland commented Sep 4, 2020 •
edited
Loading

Fixes: #3218

Summary:

  • Add Strongly typed DevTools Domain classes
  • Deprecated methods are not generated
  • Only methods (no strongly typed events yet)

Changes: [specify the structures changed]

  • Add DevToolsClient
  • Add enums/classes to represent the various domains

How Has This Been Tested?
Basic unit tests pass

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@amaitland amaitland self-assigned this Sep 4, 2020
@amaitland amaitland mentioned this pull request Sep 4, 2020
Closed
@AppVeyorBot
Copy link

✅ Build CefSharp 84.4.10-CI3684 completed (commit 94a907cbe8 by @amaitland)

@amaitland
Copy link
Member Author

amaitland commented Sep 4, 2020 •
edited
Loading

Enums aren't always being correctly specified as the type https://github.com/cefsharp/CefSharp/pull/3229/files#diff-a3bf8720232fac45e8639f5e2269cfd5R50

Also need to decorate the enum values with an attribute to map them correctly.

https://docs.microsoft.com/en-us/dotnet/api/system.runtime.serialization.enummemberattribute?view=netcore-3.1

@AppVeyorBot
Copy link

✅ Build CefSharp 84.4.10-CI3685 completed (commit b426c02cbd by @amaitland)

@AppVeyorBot
Copy link

❌ Build CefSharp 84.4.10-CI3686 failed (commit 9359d86a52 by @amaitland)

@AppVeyorBot
Copy link

❌ Build CefSharp 84.4.10-CI3687 failed (commit d64adeecef by @amaitland)

@amaitland amaitland force-pushed the enhancement/devtoolsclient branch from b535976 to f255de8 Compare September 11, 2020 06:55
@AppVeyorBot
Copy link

❌ Build CefSharp 84.4.10-CI3688 failed (commit 07e3365416 by @amaitland)

@AppVeyorBot
Copy link

❌ Build CefSharp 84.4.10-CI3689 failed (commit 55ab713cca by @amaitland)

@AppVeyorBot
Copy link

❌ Build CefSharp 84.4.10-CI3690 failed (commit 9b2f096163 by @amaitland)

@AppVeyorBot
Copy link

✅ Build CefSharp 84.4.10-CI3691 completed (commit 0e62ba4abe by @amaitland)

@AppVeyorBot
Copy link

❌ Build CefSharp 84.4.10-CI3692 failed (commit 39aabd5c33 by @amaitland)

@AppVeyorBot
Copy link

✅ Build CefSharp 84.4.10-CI3693 completed (commit 65fd17d7f7 by @amaitland)

@AppVeyorBot
Copy link

✅ Build CefSharp 84.4.10-CI3694 completed (commit c8d8612e8f by @amaitland)

@amaitland amaitland mentioned this pull request Sep 16, 2020
Closed
3 tasks
@amaitland
Copy link
Member Author

I think adding a partial method for each domain method that passes in all parameters to allow for custom validation would be worthwhile. From what I can tell there are parameters that are listed as optional yet they're conditionally optional. Set cookie you need to provide either a domain or a url.

@amaitland amaitland added this to the 85.3.x milestone Sep 18, 2020
@AppVeyorBot
Copy link

❌ Build CefSharp 84.4.10-CI3701 failed (commit 8962036917 by @amaitland)

@amaitland
Core - Add DevToolsClient
3154132 
Issue cefsharp#3165
@amaitland
DevTools Client - Add Network domain class
edf71c8 
- Add hand written class to get a better sense of how the code should be structured.
- Improve exception handling
@amaitland
Devtools - First draft of devtools protocol methods (generated)
c841ecb 
Not complete yet
@amaitland
Devtools - Simple method execution working
c0d253f
@amaitland
DevTools - Add .Net Style cased property names to response objects
ef0fdbf 
- Use internal field and datacontract attributes
@amaitland
DevTools - Improve mapping
0146d2d
@amaitland
DevTools - Strongly typed enums
0fb761e
@amaitland
DevTools Client - Generated from active browser instance (M84)
417fd5c
@amaitland
Devtools Client - Extract IDevToolsClient interface for testability
020b111 
Improve xml doc comments
@amaitland
DevTools Client - Improve error handling
4e4b624
@amaitland
DevTools Client - Improve enum conversion
d4e4344
@amaitland
Revert to older c# syntax
e036551
@amaitland
DevTools Client - Fix failing tests
edd45d7
@amaitland
Devtools Client - Add SetCookie Tests
b717085
@amaitland
DevTools Client - Add Capture SyncContext by default
201ba7b 
- Add option to capture the SyncContext
- Add option to provide custom SyncContext (can just pass in UI SyncContext and all continuations will happen there).
- Fix bug in ExecuteDevToolsMethodAsync sending the command twice when exeucted on the CEF UI thread
@amaitland
Devtools Client - Add missing file reference
6c18747 
The problem with developing with the .Net Core project where files are automatically included is you
forget to include them in the regular csproj file.
@amaitland
Devtools Client - Add CanCanEmulate Test case
6712e14
@amaitland
DevTools Client - Add AddScriptToEvaluateOnNewDocumentAsync test
b2f0dab
@amaitland
DevTools Client - OnDevToolsEvent only parse data if event handler !=…
24ff703 
… null
@amaitland amaitland force-pushed the enhancement/devtoolsclient branch from f3ac0c3 to 24ff703 Compare September 18, 2020 06:56
@AppVeyorBot
Copy link

❌ Build CefSharp 84.4.10-CI3702 failed (commit c39480b095 by @amaitland)

@amaitland
DevTools Client - GetDevToolsClient remove ThrowExceptionIfDisposed/T…
eb34e61 
…hrowExceptionIfBrowserNotInitialized calls

Those methods were removed as the GetBrowser call handles the checks for us.
@amaitland amaitland mentioned this pull request Sep 18, 2020
Closed
10 tasks
@AppVeyorBot
Copy link

❌ Build CefSharp 84.4.10-CI3703 failed (commit 981bc28f1d by @amaitland)

@amaitland
DevTools Client - Improve error handling
065a97c
@amaitland
DevTools Client - Update xml doc comments
9f50947
@amaitland
DevTools Client - Add validation method (partial)
304e4e0 
Add ability to manually add validation logic
@amaitland
DevTools Client - Comment out failing test
10c6d97 
Was working when targeting M84, now with M85 it fails.

The mapping appears to be correct, will need to investigate further
@amaitland
OffScreen Example - Remove test code
f2a1fc4
@AppVeyorBot
Copy link

✅ Build CefSharp 85.3.6-CI3706 completed (commit 94441fcdd1 by @amaitland)

@amaitland amaitland merged commit 78e32a3 into cefsharp:master Sep 21, 2020
@amaitland amaitland linked an issue Oct 6, 2020 that may be closed by this pull request
Enhancement - Add DevToolsClient (Direct Devtools Protocol) #3165
Closed
3 tasks
@amaitland amaitland mentioned this pull request Jul 2, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amaitland amaitland

Labels
None yet
Projects
None yet
Milestone
85.3.x
Development

Successfully merging this pull request may close these issues.

Enhancement - Add DevToolsClient (Direct Devtools Protocol)
2 participants
@amaitland @AppVeyorBot