Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments to make it possible to build CefSharp v37 using VS2013: #1491

Merged
merged 1 commit into from
Dec 15, 2015
Merged

Adjustments to make it possible to build CefSharp v37 using VS2013: #1491

merged 1 commit into from
Dec 15, 2015

Conversation

perlun
Copy link
Member

@perlun perlun commented Dec 15, 2015

This fixes #849, by providing a "reasonably official" CefSharp build that works correctly on Windows Server 2003 R2. Windows XP is untested, please report if it works or not.

Note: This changes the prerequisite from Visual C++ 2012 Redistributable to Visual C++ 2013 redistributable.

I have built versin 37.0.3 using this PR, and pushed it to NuGet (apart from the OffScreen package where I did not have publish rights, @amaitland 😏).

Merging.

@perlun
Adjustments to make it possible to build CefSharp v37 using VS2013:
b019537 
This fixes #849, by providing a "reasonably official" CefSharp build that works correctly on Windows Server 2003 R2. Windows XP is untested, please report if it works or not.

Note: This changes the prerequisite from Visual C++ 2012 Redistributable to Visual C++ **2013** redistributable.
perlun added a commit that referenced this pull request Dec 15, 2015
@perlun
Merge pull request #1491 from cefsharp/feature/build-with-vs2013
90013f5 
Adjustments to make it possible to build CefSharp v37 using VS2013:
@perlun perlun merged commit 90013f5 into cefsharp/37 Dec 15, 2015
@perlun perlun deleted the feature/build-with-vs2013 branch December 15, 2015 09:12
This was referenced Dec 15, 2015
Closed
Closed
amaitland
amaitland reviewed Dec 15, 2015
View reviewed changes
build.ps1
[ValidateSet("vs2013", "vs2012", "nupkg", "nupkg-only")]
[Parameter(Position = 0)]
[string] $Target = "nupkg",
[ValidateSet("vs2013", "vs2015", "nupkg-only")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libcef_dll_wrapper was only compiled with vs2012 and vs2013, so targeting vs2015 is unlikely to work.

@amaitland
Copy link
Member

I have built versin 37.0.3 using this PR, and pushed it to NuGet (apart from the OffScreen package where I did not have publish rights, @amaitland 😏).

I logged into Nuget.org and someone had already sent the request, so I'm guessing @jornh beat me to it 😄

Just as a general note, the release process typically goes something like

  • Update version numbers in build.ps1 etc (build.ps1 will update the AssemblyInfo, so not strictly required to update that, though I usually do)
  • Tag release on GitHub
  • AppVeyor builds the nuget packages and pushes them to the MyGet feed.
  • Login to MyGet and push them to Nuget.org after testing
    (My credentials are saved in MyGet, so the packages can be up pushed directly.)
  • Update ChangeLog to indicate new release.

According to MyGet you should have access to the feed already 😄

@perlun
Copy link
Member Author

perlun commented Dec 15, 2015

OK - thanks for the details. (I actually sent the request myself on Nuget.org I think 😄)

@amaitland
Copy link
Member

The user 'perlun' is already an owner or pending owner of this package.

I get that when I try to add you. If nothing appears in your email, let me know and I'll remove you then try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perlun @amaitland