Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add javadoc and source JAR plugins. #125

Merged
merged 1 commit into from
Jan 25, 2016
Merged

Add javadoc and source JAR plugins. #125

merged 1 commit into from
Jan 25, 2016

Conversation

anwar6953
Copy link
Contributor

This is needed to release hydrator-plugins 1.2.0.

bdmogal
bdmogal reviewed Jan 23, 2016
View reviewed changes
pom.xml
<version>2.9.1</version>
<configuration>
<links>
<link>http://download.oracle.com/javase/6/docs/api/</link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we use java 6? not 7 or 8? is it the same elsewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use java 7. I had just copied this from kafka pack.

@bdmogal
Copy link
Contributor

bdmogal commented Jan 23, 2016

1 question, other than that LGTM

@awholegunch
Copy link
Contributor

In the CDAP pom.xml, this is configured to match a jee.version:

  <properties>
    <jee.version>7</jee.version>
...
<link>http://docs.oracle.com/javaee/${jee.version}/api/</link>

@awholegunch
Copy link
Contributor

LGTM...

@anwar6953 anwar6953 force-pushed the update-pom-for-release branch from 540b9ef to 11fb2fb Compare January 25, 2016 20:29
anwar6953 added a commit that referenced this pull request Jan 25, 2016
@anwar6953
Merge pull request #125 from caskdata/update-pom-for-release
8c4a15f 
Add javadoc and source JAR plugins.
@anwar6953 anwar6953 merged commit 8c4a15f into release/1.2 Jan 25, 2016
@anwar6953 anwar6953 deleted the update-pom-for-release branch January 25, 2016 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anwar6953 @bdmogal @awholegunch