Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cattle-ops/terraform-aws-gitlab-runner
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7.0.0
Choose a base ref
...
head repository: cattle-ops/terraform-aws-gitlab-runner
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7.1.0
Choose a head ref
  • 3 commits
  • 9 files changed
  • 5 contributors

Commits on Sep 28, 2023

  1. feat: add MaxGrowthRate to limit the number of instances added in p… 

    …arallel (#962)

## Description

This feature allows to support `MaxGrowthRate` which limits the number
of instances added in parallel by the Runner. The default of `0`
(unlimited) is used if no value is given.

The parameter is added to `runner_worker_docker_machine_instance` as
this is the only Runner type for which it makes sense. All other types
are not able to scale and thus it is not a `runner_worker` parameter.

See
[advanced-configuration](https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-runnersmachine-section)

Closes #851 

## Migrations required

NO

## Verification

- do not set the parameter --> `MaxGrowthRate` in config file is 0.
- set the parameter to any value --> `MaxGrowthRate` in config file is
"any value"

---------

Co-authored-by: Matthias Kay <github@matthiaskay.de>
Co-authored-by: Matthias Kay <matthias.kay@hlag.com>
    @rohaquinlop @kayman-mk
    3 people authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    ae6d38a View commit details
    Browse the repository at this point in the history

  2. fix: convert the fleet instance type in migration script (#975) 

    ## Description

The instance types for the fleet are not converted. In this case the
module uses a default value `m5.large`. So all created instances are
`m5.large` instances which is usually not wanted.

If the migration script was used to convert the module call to version
7, it is very likely that you find the following in your module call:
```hcl
runner_instance = {
    docker_machine_types_fleet = ["t3.medium"] # your instance types here
}
```

The variable `docker_machine_types_fleet` does not exist, but Terraform
does not report an error.

This PR fixes the migration script and produces the following correct
code:
```hcl
runner_worker_docker_machine_instance = {
  types                    = ["t3.medium"]
}
```

## Migrations required

No

## Verification

Verified locally that the script produces the output as described above.
    @kayman-mk
    kayman-mk authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    51b2842 View commit details
    Browse the repository at this point in the history

  3. chore(main): release 7.1.0 (#972) 

    🤖 I have created a release *beep* *boop*
---


##
[7.1.0](7.0.0...7.1.0)
(2023-09-28)


### Features

* add `MaxGrowthRate` to limit the number of instances added in parallel
([#962](#962))
([ae6d38a](ae6d38a))


### Bug Fixes

* convert the fleet instance type in migration script
([#975](#975))
([51b2842](51b2842))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: Niek Palm <dev.npalm@gmail.com>
Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    @cattle-ops-releaser-2 @github-actions
    cattle-ops-releaser-2[bot] and github-actions[bot] authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5d3f681 View commit details
    Browse the repository at this point in the history
Loading