Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace @_ctp_status_bg with @thm_surface_0 in module configurtion to properly show module separation #380

Merged
merged 2 commits into from
Oct 19, 2024
Merged

fix: replace @_ctp_status_bg with @thm_surface_0 in module configurtion to properly show module separation #380

merged 2 commits into from
Oct 19, 2024

Conversation

xafarr
Copy link
Contributor

@xafarr xafarr commented Oct 17, 2024 •
edited by sgoudham
Loading

Before the change:
With @catppuccin_status_connect_separator set to yes or no
Screenshot 2024-10-17 at 12 04 22 pm

After the change:
With @catppuccin_status_connect_separator set to yes
Screenshot 2024-10-17 at 12 09 50 pm

With @catppuccin_status_connect_separator set to no
Screenshot 2024-10-17 at 12 08 59 pm

BEGIN_COMMIT_OVERRIDE
feat: replace _ctp_status_bg with unified _ctp_module_bg_color in module configuration
END_COMMIT_OVERRIDE

@xafarr xafarr mentioned this pull request Oct 17, 2024
Closed
1 task
kjnsn
kjnsn reviewed Oct 17, 2024
View reviewed changes
utils/status_module.conf Outdated Show resolved Hide resolved
bvelastegui
bvelastegui reviewed Oct 18, 2024
View reviewed changes
Copy link

@bvelastegui bvelastegui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kjnsn kjnsn merged commit a4d4ad0 into catppuccin:main Oct 19, 2024
1 of 2 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Merged
@kjnsn
Copy link
Collaborator

kjnsn commented Oct 19, 2024

Thanks so much! This will be released in v2

pauldthomson pushed a commit to pauldthomson/tmux that referenced this pull request Nov 14, 2024
@xafarr @kjnsn @pauldthomson
feat: replace @_ctp_status_bg with @thm_surface_0 in module configurt…
3344f9a 
…ion to properly show module separation (catppuccin#380)

* fix: module bg color blending in with status line bg color preventing the seperator to be visible


---------

Co-authored-by: Kaley Main <kaleymain@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvelastegui bvelastegui bvelastegui left review comments

@kjnsn kjnsn kjnsn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xafarr @kjnsn @bvelastegui