feat(window_tabs_enabled): Adding support for window tabs rather than directory tabs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option, for now, defaults to false. This is just so it keeps the initial design intention for the original design of the plugin. I may flip it or change the name of the variable in future commits. This patch is addressing catppuccin#16. Co-Authored-By: Robert Menke <robert.b.menke@gmail.com>
|
I don't see a |
This is the start of plumbing things through into the theme files, but I do think that there is a better way here. I'm open to suggestions and will probably ask for some help in the Discord for Catppuccin.
I'm aiming for having the Style Guide more exposed in the documentation. I'm expecting to be able to reference it if people start asking for things that would go against the guide. Also if anything I write that follows the guide but isn't accessible then maybe I can contribute back to the guide.
This file should be ignored as it's getting modified by the main script to pull in the themes for each flavor of Catppuccin in a safe way for users running this script.
So the idea here is that the themes are only different based on the variables for the theme files. So this will change the theme variables to have `local` prefixes to keep the namespace regular. I decided to keep this like this until I get more feedback, because I think I could also just manually add the local to everything in the old `tmuxtheme` files. I chose this though because I really like how the `catppuccin-selected-theme` can be used for local debugging or testing out new colors if things were ever to need to be changed. If what that `sed` and `source` command is doing is unclear, I can do better about commenting around it.
This architecture is now more extensible since all the display variables are decoupled from where the options get set. This will make customizing the theme with custom scripts more practical.
This patch adds the functionality necessary to setup @catppuccin_window_tabs_enabled for folks who expect something differently than the initial design.
This decoupling was done in a previous patch 0d82738 and I missed this. So I went back to fix it.
rogeruiz
added a commit
to rogeruiz/tmux
that referenced
this pull request
Nov 25, 2022
I hadn't realized this earlier but we need to include the executable here with the theme files since those alone wouldn't be enough after catppuccin#22 is merged in. Figured it out with @DakshG07's help. Co-authored-by: Dukk <48651837+DakshG07@users.noreply.github.com>
6 tasks
rogeruiz
added a commit
to rogeruiz/tmux
that referenced
this pull request
Nov 30, 2022
I'm doing this since I don't want to have to rebase things. But I wanted to make sure that I make this branch easy to merge into the default branch whenever catppuccin#22 is approved and merged in. Merge branch 'add-option-to-display-folders' into add-zoom-indicator
|
discussed with @pocco81 in Discord about this being reviewed and good. 👍🏽 |
rogeruiz
added a commit
to rogeruiz/tmux
that referenced
this pull request
Dec 14, 2022
I hadn't realized this earlier but we need to include the executable here with the theme files since those alone wouldn't be enough after catppuccin#22 is merged in. Figured it out with @DakshG07's help. Co-authored-by: Dukk <48651837+DakshG07@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option, for now, defaults to
false. This is just so it keeps theinitial design intention for the original design of the plugin. I may
flip it or change the name of the variable in future commits. This patch
is addressing #16.
Alright, this closes #16 when it's merged into the default branch. If anyone would like to test this out locally, you should be able to set a new remote to my GH fork and then change branches to
add-option-to-display-folders.The commands to do that in your local Git repository should be:
Afterwards, you can follow the documentation in the
README.mdto turn on the feature. Remember to source your Tmux configuration file when you update it if you're in a session.When you're done, you can remove the remote and go back to the default branch with the following: