Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify the color for right separator of the status modules to be the same as text bg color #429

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

xafarr
Copy link
Contributor

@xafarr xafarr commented Nov 10, 2024

Before

  1. When a right separator for status module is specified then the color of the foreground is not same as the text background color.
  2. There's no space between the windows when the status style is rounded making it look awkward
Screenshot 2024-11-11 at 9 17 52 am

After the change

Screenshot 2024-11-11 at 10 00 45 am

@kjnsn
Copy link
Collaborator

kjnsn commented Nov 11, 2024

I have a few questions here:

  1. For the space between windows, what is wrong with window-status-separator?
  2. This will break other people's configurations, can you achieve the same thing by modifying your own config?
  3. Does setting @catppuccin_status_right_separator "#[fg=#{@_ctp_module_text_bg}]\uE0B4" not work?

@xafarr
Copy link
Contributor Author

xafarr commented Nov 11, 2024

Good questions. Let me answer respectively.

For the space between windows, what is wrong with window-status-separator?

If you see the windows under Before heading are squished together and don't look as mentioned in the documentation, and also is different from how it looked previously. Please have a look at the attached screenshots below (look at the red circle).

Actual

Screenshot 2024-11-11 at 9 17 52 am

Documentation

Screenshot 2024-11-11 at 11 29 38 am

This will break other people's configurations, can you achieve the same thing by modifying your own config?

Can you please explain how will it break other people's configurations? It can be done but it's a too low-level configuration for the user in my opinion. At least it should look like the example configuration.

Does setting @catppuccin_status_right_separator "#[fg=#{@_ctp_module_text_bg}]\uE0B4" not work?

It will work (haven't tried it) but isn't the expectation would be that the right separator should be of the same color as the text background. Same as how the left separator has the fg set, the right separator fg has to be set.

Screenshot 2024-11-11 at 11 44 00 am

@kjnsn
Copy link
Collaborator

kjnsn commented Nov 11, 2024

Good questions. Let me answer respectively.

For the space between windows, what is wrong with window-status-separator?

If you see the windows under Before heading are squished together and don't look as mentioned in the documentation, and also is different from how it looked previously.

Yep I can see that. If you add set -g window-status-separator ' ' in your config does the same thing happen? See the philosophy doc on orthogonality of features; I don't want to add a feature that already exists in tmux itself.

This will break other people's configurations, can you achieve the same thing by modifying your own config?

Can you please explain how will it break other people's configurations? It can be done but it's a too low-level configuration for the user in my opinion. At least it should look like the example configuration.

Does setting @catppuccin_status_right_separator "#[fg=#{@_ctp_module_text_bg}]\uE0B4" not work?

It will work (haven't tried it) but isn't the expectation would be that the right separator should be of the same color as the text background. Same as how the left separator has the fg set, the right separator fg has to be set.

I made the decision to not do this to increase flexibility. You can have a space or text as the right separator if desired. This change means that those configs will break.

Tmux is generally quite difficult to configure and style. There are things like tmux-powerilne that make it easier at the cost of flexibility. I would prefer to expose only primitive styling in this plugin, with the hope that other things can be built on top of it. For example I'd love to see a "catppuccin powerline" repo somewhere that someone made

@xafarr
Copy link
Contributor Author

xafarr commented Nov 11, 2024

Yep I can see that. If you add set -g window-status-separator ' ' in your config does the same thing happen? See the philosophy doc on orthogonality of features; I don't want to add a feature that already exists in tmux itself.

I think this makes sense and setting the window-status-separator works the same way. Good call. I'll remove this change.

Does setting @catppuccin_status_right_separator "#[fg=#{@_ctp_module_text_bg}]\uE0B4" not work?

This doesn't work or may be I'm doing something wrong.

I made the decision to not do this to increase flexibility. You can have a space or text as the right separator if desired. This change means that those configs will break.

Wouldn't you expect the same color for the separator even if it's a space? For the text something like #[fg=#00000]Text can be added as the separator value.

@xafarr
Copy link
Contributor Author

xafarr commented Nov 12, 2024

Does setting @catppuccin_status_right_separator "#[fg=#{@_ctp_module_text_bg}]\uE0B4" not work?

It works if we make the following change in status_module.conf

Screenshot 2024-11-12 at 9 15 15 pm

@xafarr
Copy link
Contributor Author

xafarr commented Nov 12, 2024

If you have a disagreement with the proposed changes then please make the change in my last comment and I'll close this PR. Thanks a lot for your work.

@kjnsn kjnsn changed the title fix: specify the color for right separator of the status modules to be the same as text bg color and fix space among windows fix: specify the color for right separator of the status modules to be the same as text bg color Nov 17, 2024
@kjnsn kjnsn merged commit 0e66dee into catppuccin:main Nov 17, 2024
2 checks passed
@xafarr xafarr deleted the fix-separator-color branch November 20, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants