revert: "raise amount of itemgroup tests from 100 -> 1000" #5872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8eab8a6.
chaosvolt
approved these changes
Jan 4, 2025
RobbieNeko
changed the title
|
This is a revert of a commit with no dependents, so I'm willing to be laxxer on the testing requirements. No need to wait the full duration for builds we know will succeed. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
mainso it won't cause conflict when updatingmainbranch later.Purpose of change
The previous PR set it so item groups were tested at 1000 hits. This isn't useful to us for getting an accurate picture of what will likely spawn in a run. This has caused difficulty for Chaosvolt and I to work on item groups, and caused Chaosvolt to overlook a flaw in my drugdeal itemgroup PR where he disagreed with my specific spawnrates.
Describe the solution
Github Revert
Describe alternatives you've considered
Make Oren code it to be configurable.
Testing
Don't need to, it's an automatic Git Revert.
Additional context
#5033