-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Advanced Object Deconstruction no longer hides deconstruction results #5867
fix: Advanced Object Deconstruction no longer hides deconstruction results #5867
Conversation
…econstruction field
…p, but it doesn't hurt to be careful.
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
doc/
folder.Purpose of change
The change that broadened the use of Advanced Object Deconstruction also deprived players of information on what deconstructing given objects (largely electronics) could produce. This made hunting for specific parts somewhat frustrating, most of all for new players.
Describe the solution
There are a few different factors here.
ADV_DECONSTRUCT
, which (currently) marks something that can't be deconstructed by "Deconstruct (Simple) Furniture".e
xamination, so there wasn't really any clean way around this.)Describe alternatives you've considered
map_data_common_t::extended_description
to cross-reference construction results for information. This was also a pretty terrible idea.Testing
Load the game;
e
xamine an AOD object (I used computer terminals, amongst other things); try using Furniture Deconstruction on said object (it won't be listed as possible). Use AOD on it, it should disassemble properly.Add "post_terrain" or "post_furniture" to an AOD entry that has
"post_special": "done_deconstruct"
, try to load the game, get an error about why it refuses to load.Additional context
This essentially makes each AOD entry function like
constr_deconstruct
(Furniture Deconstruction), but denies that from working on said objects. That means that the game can still reference deconstruction fields (which also keeps terrain information in one place instead of spread out into "byproducts"), while still imposing restrictions on how something is deconstructed. It also means the Hitchhiker's Guide will neatly display deconstruction results again.As an additional bonus, it also means deconstruction results spawn on the tile that was deconstructed, instead of being dropped under the players' feet. That really got on my nerves.