Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): allow alternatives to rubber gloves for deconstruction, moved advanced deconstruct to OTHER #5865

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

Two simple adjustments to advanced object deconstruction.

Describe the solution

  1. Set the high-voltage deconstruction to allow faraday chainmail suits and faraday shark suits as alternatives to rubber gloves. Done this way instead of using sub because those aren't of type TOOL_ARMOR and thus would scream on load if slapped with sub.
  2. Did however outright add sub definitions to industrial exo-suits since those can have it without issue.
  3. Moved all advanced object deconstruction recipes from CONSTRUCT to OTHER where regular deconstruction currently resides.
  4. Misc: Added a comment to the toolset for high-voltage tools mentioning what needs to be defined as a tool to use in place of rubber gloves explicitly vs being a substitute too.

Describe alternatives you've considered

We could just flat-out set all items that have the ELECTRIC_IMMUNE flag as a substitute, but as noted we'd also want to convert them to tool armor to enable that.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build.

image

Additional context

As I commented in the relevant issue, and the reason why I didn't mark this PR as fixing the issue just yet, I additionally want to give the diaelectric capacitance tool a fake item that counts as an alternative way to do high-voltage work. Main issue is right now if I want it to require charges of bionic power to work I have to either:

  1. Hardcode it in like I already did during fix: electrosense CBM's voltmeter can be used in advanced deconstruction #5744
  2. Scream at C++ until I can unhardcode charge consumption of bionic fake tools.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 2, 2025
@chaosvolt chaosvolt merged commit 9df762b into cataclysmbnteam:main Jan 2, 2025
13 checks passed
@chaosvolt chaosvolt deleted the haha-spicy-wires branch January 2, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants