Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more harvest entries have blood #5843

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

This fixes yet more harvest entries that were missing blood.

Describe the solution

  1. Added animal blood to all the fish harvest entries, and mutant blood to mutant_fish and mutant_fish_large. Shellfish and lobster were left untouched since we don't have an item for wacky hemolyph-type stuff yet.
  2. Added mutant blood to a bunch of mutant human harvest entries that were lacking them.
  3. mammal_large_chitin was also missing mutie blood, fixed that.
  4. Since we went ahead and already added blood to super-tiny mammals and now fish, added it to bird_tiny too, and also fixed bird_large lacking mutant blood.
  5. inucubator_mammal given blood since it isn't dead yet, but I gave it a special exception to the normal ratio and let it have half the amount that's normal.

Describe alternatives you've considered

Skeletal harvest entries were left alone since they don't spawn blood fields when shot.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Double-checked the types of blood I picked make sense for the entries they were given to.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 27, 2024
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be blood. Shed.

The dragon in the mirror screams at his head.

Copy link
Collaborator

@RobbieNeko RobbieNeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blood for the blood gods!

@chaosvolt chaosvolt merged commit 1a0e902 into cataclysmbnteam:main Dec 27, 2024
13 checks passed
@chaosvolt chaosvolt deleted the blood-for-the-blood-god branch December 27, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants