Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use regional terrain for s_petstore #5842

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

0Monet
Copy link
Contributor

@0Monet 0Monet commented Dec 27, 2024

Checklist

Required

Purpose of change

Use the regional terrain for the mapgen s_petstore and modify the size of the parking lot in front of the store to suit the size of the cars in the game.

Describe the solution

Replace non-regional outdoor terrain with pseudo-regional terrain.

Describe alternatives you've considered

none

Additional context

Before:
image1
After:
image2

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 27, 2024
Copy link
Collaborator

@RobbieNeko RobbieNeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd question removing the weight from the entry, but here it appears to be just making it more consistent with the rest of the entries in the file.

Consistency goes brr

@RobbieNeko RobbieNeko merged commit d50e843 into cataclysmbnteam:main Dec 27, 2024
13 checks passed
@0Monet
Copy link
Contributor Author

0Monet commented Dec 27, 2024

I removed weight because there is no other mapgen with the same id in the file.

@0Monet 0Monet deleted the regional-s_petstore branch December 27, 2024 18:14
@RobbieNeko
Copy link
Collaborator

Ah, makes perfect sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants