Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Let tarps actually shelter fires, let fire rings be used more #5834

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

RobbieNeko
Copy link
Collaborator

Checklist

Required

Purpose of change

The tarp lean-to's description said it could be used to shelter a fire, but it could not. This lets it be accurate to its description (and have other furniture too I guess)

The fire ring was restricted to only being placeable on specifically dirt and nothing else. This felt like an unnecessary restriction (and didn't allow for the fire ring to be sheltered by the tarp), so I opted to just let it be constructed on any (FLAT) terrain.

Describe the solution

  • Adds FLAT to the tarp lean-to
  • Removes the pre-terrain requirement in the fire ring's construction

Describe alternatives you've considered

  • Specifically allow the fire ring to also be constructed on the tarp lean-to

This doesn't actually solve the issue, because there are innumerable sensible FLAT terrain options that it could be put on, and manually adding them all would be ridiculous. Also, it's not like having a fire ring on any of these terrain types is an actual balance issue.

Testing

It works, but it looks silly
image

Additional context

Maybe we should have a flag that can be put on terrain that says to put the terrain's sprite on a higher layer than the furniture sprite for situations like this.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 26, 2024
@scarf005 scarf005 merged commit 4f44eeb into cataclysmbnteam:main Dec 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants