Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More engine recipes #5816

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Conversation

Berehenia
Copy link
Contributor

Added recipes for v6, v8, v12, inline and their counterparts for diesel. Added engine block recipes, added all 3 gas turbine recipes as well.

Checklist

Required

Optional

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Added recipes for v6, v8, v12, inline and their counterparts for diesel. Added engine block recipes, added all 3 gas turbine recipes as well.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 17, 2024
@scarf005 scarf005 changed the title feat: More engine stuff feat: More engine recipes Dec 17, 2024
@karxi
Copy link
Contributor

karxi commented Dec 19, 2024

Bluntly, I don't think turbines should be craftable. They're not terribly hard to find (the sole exception being osprey engines); they're located in military helipads. At most, I'd suggest limiting it to the smallest turbine engine.
Unless we're planning to allow players to craft turbines for high-efficiency generators, in which case my objections hold less weight. (Which I don't think is a terrible idea, but I'm not the one doing an energy rework.)

@Coolthulhu
Copy link
Member

Yeah, turbines should be effectively "non-renewable", using something uncraftable and high level as ingredient.
V12s could be craftable, but they should probably consume some semi-rare, uncraftable component. Not sure what would be a good candidate.

I recall there being some sort of sci-fi fabricator machine in one of the collapsed buildings. If I remember correctly, it uses rare, uncraftable "unobtainium containers" to create things.
I'd be fine with turbines being craftable using something from that fabricator, plus a couple of superalloy plates.

@Berehenia
Copy link
Contributor Author

The nanofabricator is kinda rare as all hell

Its not guaranteed to be the lab finale
its not guaranteed to have the nanofab template for it (iirc you can only craft from nano canisters there so it'd take 400 kilos or around 30 of them)
So that would be a lot more lab or sarcophagus diving than anything else in the game

Its a bit too brutal of a requirement
The main point of this recipe suggestion is to kill off RNG even if you need to grind your ass off

The small turbine is 7 in fabrication as main stat and 7 in mechanics, and 3 alloy plates (36 sheets total)
The largest one eats 6 superalloy plates and requires 10 in fab (probably more annoying than mechanics by a long shot) and mechanics plus a massive engine block which is either taking apart a v12 or crafting one (6 mechanics is what i suggested for it, im down for number adjustments (and i think it could be bumped to 8 easily) )

The 6k one also doesnt have a uncraft while the vehicle part breaks into 4-6 plates and only a bunch of steel

Hell, I wouldn't mind adding electrics as an requirement as well or making the recipe far more annoying

What do y'all think?

@RobbieNeko
Copy link
Collaborator

I think that the largest turbine variant should remain something you find, but am perfectly fine with the small variant and even the medium variant.
Everything else looks great in my opinion!

Copy link
Collaborator

@yay855 yay855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The large turbine recipe should be removed at the very least, in order to get players to seek it out for their supercars and helicopters. I personally also think the larger regular engine recipes should be removed as well, but not every dev agrees with me on that, so I won't push it.

Berehenia and others added 2 commits December 28, 2024 00:07
Removes turbine recipes, added complex pump recipe, tweaked engine recipes slightly
Copy link
Contributor

autofix-ci bot commented Dec 27, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

Copy link
Collaborator

@RobbieNeko RobbieNeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@yay855 yay855 merged commit 262fa72 into cataclysmbnteam:main Dec 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Required JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants