Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: raise amount of itemgroup tests from 100 -> 1000 #5033

Merged
merged 1 commit into from
Jul 21, 2024
Merged

feat: raise amount of itemgroup tests from 100 -> 1000 #5033

merged 1 commit into from
Jul 21, 2024

Conversation

Lamandus
Copy link
Contributor

@Lamandus Lamandus commented Jul 21, 2024 •
edited
Loading

Checklist

Required

Optional

Purpose of change

100 item-group tests were not enough nowadays, a lot of tests are in the percentile instead of percent.

Describe the solution

Raise tests spawns form 100 -> 1000

Describe alternatives you've considered

Testing

grafik
grafik

Additional context

@github-actions github-actions bot added the src changes related to source code. label Jul 21, 2024
chaosvolt
chaosvolt approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still kinda mixed about this. More sample size is good, but it will hinder readability and getting an actual sense of how an itemgroup looks.

@Lamandus
Copy link
Contributor Author

Lamandus commented Jul 21, 2024 •
edited
Loading

I get you, but the sample size has some pros.

the lower example, you would have to /10 to get the system we have now, as you can see, it would lead to a lot of bunching (anything up to 10 would be 1, 11-20 -> 2, etc., Now we can see more finer details. This test would have gone just to "7 x"

@chaosvolt chaosvolt merged commit 8eab8a6 into cataclysmbnteam:main Jul 21, 2024
8 checks passed
@Lamandus
Copy link
Contributor Author

d9f3xto-4cf1a063-27fe-47d4-9c57-bc4cc9ad4855

@Lamandus Lamandus deleted the itemgroup branch September 4, 2024 23:23
@chaosvolt chaosvolt mentioned this pull request Jan 2, 2025
Open
4 tasks
RoyalFox2140 added a commit that referenced this pull request Jan 4, 2025
@RoyalFox2140
Revert "feat: raise amount of itemgroup tests from 100 -> 1000 (#5033)"
bd1b6c6 
This reverts commit 8eab8a6.
@RoyalFox2140 RoyalFox2140 mentioned this pull request Jan 4, 2025
Merged
4 tasks
RobbieNeko pushed a commit that referenced this pull request Jan 4, 2025
@RoyalFox2140
revert: "raise amount of itemgroup tests from 100 -> 1000" (#5872)
10ee78c 
Revert "feat: raise amount of itemgroup tests from 100 -> 1000 (#5033)"

This reverts commit 8eab8a6.
@OrenAudeles OrenAudeles mentioned this pull request Jan 4, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaosvolt chaosvolt chaosvolt approved these changes

Assignees
No one assigned
Labels
src changes related to source code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lamandus @chaosvolt