Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): add house_fence10 #4946

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

LilShiningMan
Copy link
Contributor

Checklist

Required

Purpose of change

more houses

Describe the solution

add another house

Describe alternatives you've considered

Testing

linted and spawned in game

Additional context

I also upped the weight of all the house_fence series of houses. I still want them to be a little less likely to spawn than other houses, but I figure they should have more like spawn rate 30 than 20.

image
basement a

image
basement b

image
ground

image
second floor

image
roof

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jul 7, 2024
@scarf005 scarf005 merged commit ac04fee into cataclysmbnteam:main Jul 7, 2024
10 checks passed
@Relgar
Copy link
Contributor

Relgar commented Jul 7, 2024

Love the work @LilShiningMan , are you considering houses which have voids in future contributions? I feel this adds variety.

@LilShiningMan
Copy link
Contributor Author

sorry, not sure what you mean by "voids"?

@chaosvolt
Copy link
Member

I'm guessing he's referring to some houses that might still have big empty patches in them. Not sure how common that is compared to basements which have been more well-known for their emptiness, but you've also tackled those so I'm not sure how common that is anymore either. Good work in any case. :D

@Relgar
Copy link
Contributor

Relgar commented Jul 8, 2024

A void in building construction is a space on the 2nd story that lets you look down on to the 1st/ground floor, similar to the below:

https://www.mindfood.com/wp-content/uploads/2021/07/MET2773_Riviera_Heroes_368-002.jpg

This lets the house look bigger and adds some verticality to the house, which may be interesting if you have zombies on the 2nd floor who see the player sneaking about. Typically have glass barriers.

@chaosvolt
Copy link
Member

Oh, that could be interesting in some houses maybe.

@LilShiningMan
Copy link
Contributor Author

Ah, ok. Yes, I've added at least two houses (more?) which have voids so far

image
2Story02

image
2StoryModern05

I find that layout interesting and I'd like to add more. I'd like to get away from the 1 story and focus more on verticality going forward.

@LilShiningMan LilShiningMan deleted the add-house_fence10 branch July 10, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants