Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): define crafting quality for superglue and bone glue, adjustments to relevant recipes #4919

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Purpose of change

This rebalances the use of bone glue vs superglue, and tweaks a few recipes that use adhesives and superglue.

Describe the solution

  1. Defined adhesive_proper crafting quality, for recipes where superglue or bone glue are reasonable but tape shouldn't be allowed. In addition, it now uses 2 bone glue per 1 superglue, making superglue properly more efficient and fixing the oddity where making superglue from 20 bones offered no benefit when bone glue only needed 10 bones for the same number of charges.
  2. Reworked adhesive and nail_glue to use adhesive_proper inside them in place of superglue or bone glue.
  3. Updated makeshift macuahuitl recipe to require hammering and cutting quality since you're likely having to shape the rocks into blades and set them in the edges of the club, implemented use of adhesive_proper and wood_structural_small crafting qualities for the recipe, removed extraneous empty tool section, set to no longer be reversible since knapped blades.
  4. Updated glue use of glass caltrops and bow dampener recipes to use adhesive_proper crafting qualities.
  5. Allowed exploding arrow warheads, ski goggles, and duct tape recipes to use adhesive_proper instead of just superglue. I figured keep it using superglue only for caseless ammo, airtight uses like gas mask filters, and electronics but less fiddly uses seem reasonable to permit it.
  6. Set composite bow recipes to all use adhesive_proper instead of adhesive, as the idea is the composite material is traditionally held together with horn glue, and also added them as components to composite greatbow and composite crossbow.
  7. Misc: Fixed bagpipes recipe adding medical tape to components on top of adhesives requirement.
  8. Updated demon cauldron recipe in Magiclysm to use adhesive_proper instead of just bone glue.

Describe alternatives you've considered

Mainlining tar oil and pitch from MST Extra so I have to remove my overrides to crafting qualities there instead of just updating them.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Ported changes to test build and load-tested.

Additional context

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Jul 1, 2024
chaosvolt added a commit to chaosvolt/MST_Extra_Mod that referenced this pull request Jul 1, 2024
Belated response to updates to glue production and rebalancing in preparation for cataclysmbnteam/Cataclysm-BN#4919
@scarf005 scarf005 merged commit 64e281c into cataclysmbnteam:main Jul 2, 2024
10 checks passed
@chaosvolt chaosvolt deleted the macuahuitl-goes-nyoom branch July 2, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants