Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: less crashing while auto-driving, smoother driving style #4683

Merged
merged 2 commits into from
May 22, 2024

Conversation

Lamandus
Copy link
Contributor

@Lamandus Lamandus commented May 22, 2024

Purpose of change

This change will make auto-drive a bit safer. It lowers the speed which are needed to turn the steering wheel leading to better reaction to different obstacles.

Describe the solution

Lowering the move cost to 0. raise the "space needed on the sides" for either braking or canceling auto-drive.

Describe alternatives you've considered

Testing

Aufzeichnung.2024-05-22.101920.mp4

Additional context

Checklist

@github-actions github-actions bot added the src changes related to source code. label May 22, 2024
@Lamandus Lamandus changed the title fix: less crashing while auto-driving, smoother driving skill fix: less crashing while auto-driving, smoother driving style May 22, 2024
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as there has been numerous number tweaking PRs before, i think it'd be better UX to add option for min and max driving speed in settings rather than fine-tuning them.

for example, please check similar PRs such as: #4451

@Lamandus
Copy link
Contributor Author

as there has been numerous number tweaking PRs before, i think it'd be better UX to add option for min and max driving speed in settings rather than fine-tuning them.

for example, please check similar PRs such as: #4451

ok, the change in speed will be removed, but the rest is not affected in #4684

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hecc

@chaosvolt chaosvolt requested a review from scarf005 May 22, 2024 18:36
@chaosvolt chaosvolt enabled auto-merge (squash) May 22, 2024 18:36
@chaosvolt chaosvolt merged commit a2500ea into cataclysmbnteam:main May 22, 2024
13 checks passed
@Lamandus Lamandus deleted the crash-free branch September 4, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants