Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port body part code from DDA up to May 4 #406

Merged
merged 4 commits into from
Mar 25, 2021
Merged

Port body part code from DDA up to May 4 #406

merged 4 commits into from
Mar 25, 2021

Conversation

Coolthulhu
Copy link
Member

No new features, but it will be useful in the future.
DDA code all by Fris0uman, plus some BN-specific fixes from me.

@Coolthulhu Coolthulhu merged commit d9db2c6 into upload Mar 25, 2021
@Coolthulhu Coolthulhu deleted the port-bp branch April 3, 2021 09:35
@chaosvolt
Copy link
Member

chaosvolt commented Apr 12, 2021

Question: does this only affect the bodypart IDs of CBMs and mutations, or is clothing affected too? Recent test revealed that CBMs seem to now consider the DDA-style lowercase ID to be required or else it'll fail to recognize, would need to make sure what all I'll need to fix for third-party mods besides CBMs.

EDIT: From testing so far it seems only CBMs require lowercase BP IDs to work right, mutations and clothes SEEM to still work with either from what I've seen.

@Coolthulhu
Copy link
Member Author

Recent test revealed that CBMs seem to now consider the DDA-style lowercase ID to be required or else it'll fail to recognize, would need to make sure what all I'll need to fix for third-party mods besides CBMs.

Clothing has one ugly edge case at the moment: you need uppercase for one-side items.

@chaosvolt
Copy link
Member

Clothing has one ugly edge case at the moment: you need uppercase for one-side items.

That's what I was suspecting yeah, since DDA defines switchable items in a very different way. For now it looks like CBMs are the only case where lowercase BP IDs are mandatory now, but I'll try to keep an eye on things and update third-party mods accordingly.

@Coolthulhu
Copy link
Member Author

That's what I was suspecting yeah, since DDA defines switchable items in a very different way.

I'll want to port it since it's next to trivial. It's just not done yet, since I didn't want to bundle it with ports.

@chaosvolt
Copy link
Member

No worries, hope it goes well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants