Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grid appliances refund solder on deconstruction #3475

Merged

Conversation

YeOldeMiller
Copy link
Contributor

@YeOldeMiller YeOldeMiller commented Oct 21, 2023

Summary

SUMMARY: Balance "Make grid appliances refund solder on deconstruction"

Purpose of change

Deconstructing grid furniture does not return the 20 solder spent on connecting it. Solder can be somewhat hard to procure early on, so simply rearranging items in player's base comes at an unreasonable cost that's both unrealistic and adds nothing gameplay-wise, especially considering that installing those same appliances into a vehicle is free, not counting tool charges.

In short, moving around things player already has should not have noticeable resource costs.

Describe the solution

Adjust JSON entries for all grid furniture, adding 20 solder to deconstruct items, as well as range of 10-20 solder to bash items (10 and 5-10 respectively for the few articles that cost 10 to install). Additionally, adjust both battery chargers to always return 5 copper wire, and both types of solar panels to return 5 steel chunks, to follow the pattern of grid appliances always refunding full amount of resources required for their installation.

UPD: also make fixed the material costs for storage battery grid housing (metal sheets and copper wires).

Describe alternatives you've considered

Removing the solder cost altogether comes to mind, but that's a bit too easy, and likely more work than this.

Testing

Deconstruct various existing and newly installed grid furniture items, making sure the resources refunded include solder, and amounts are no longer random where applicable.

Additional context

Disassembling other electronic items in the game already yields solder, and craftable items refund 100% solder, so the change is consistent with that.
Recovering used solder is fairly realistic and something repairmen do when short. The only thing permanently expended is negligible amounts of rosin, which isn't at all a scarce resource in the game and thus can be ignored.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 21, 2023
@scarf005 scarf005 requested a review from chaosvolt October 21, 2023 13:51
@scarf005
Copy link
Member

@YeOldeMiller i think this PR is good as-is, please feel free to tell me if anything's wrong. it's perfectly fine for autofix bot to apply fixes.

@YeOldeMiller
Copy link
Contributor Author

Sorry, just discovered a few entries I missed. I'll reopen as soon as I sort them out.

@YeOldeMiller YeOldeMiller reopened this Oct 21, 2023
@scarf005
Copy link
Member

image
oh, if you're working on the PR and would like to mark it as unfinished, try using draft

@YeOldeMiller
Copy link
Contributor Author

Good to know, thanks, will do that next time.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell ye, one of my misc. entries on my todo list is to make deconstructs for stuff you can build no longer absurdly lossy so this makes things easier for when I eventually actually tackle that.

Getting back solder is probably unrealismic but it's currently such CBT to make and such a crapshoot to find reliably that this is probably reasonable. If I ever rework the recipe for copper wire and solder then maybe making them go back to being lossy is probably fine, but for now...

Also ported the file change to my build and no errors, so. :3

@chaosvolt chaosvolt added this pull request to the merge queue Oct 21, 2023
@RobbieNeko
Copy link
Collaborator

Getting back solder is probably unrealismic but it's currently such CBT to make and such a crapshoot to find reliably that this is probably reasonable. If I ever rework the recipe for copper wire and solder then maybe making them go back to being lossy is probably fine, but for now...

If we were DDA, we'd probably just split solder into a version with flux and a version without, then make any sort of deconstruct or uncraft give back the unfluxed version. But that seems a bit too asinine for us :P

@YeOldeMiller
Copy link
Contributor Author

I mean, in DDA you just plug and unplug stuff at no expense at all...
Even if we assume that you have to build in a power converter to use battery power, that can be done in a modular way. The need to build even items like soldering iron into stationary furniture versions to use power grid is, quite frankly, a crutch. No need to draw extra attention to it with unreasonably annoying resource management.

@scarf005
Copy link
Member

scarf005 commented Oct 21, 2023

i'm not against removing soldering iron requirement entirely. or any requirements, even. the UI already is painful, no need to add more.

@YeOldeMiller
Copy link
Contributor Author

I don't actually mind the crafting requirements. Hell, I started playing Cata for the complex crafting system. It's just that I'm OCD enough about my base layout even without the knowledge that I'll be taxed every time I decide to change placement of certain items. That I can do without xD

Merged via the queue into cataclysmbnteam:upload with commit 027a3c4 Oct 21, 2023
@YeOldeMiller YeOldeMiller deleted the feature/grid-solder-fix branch December 13, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants