Fix possible segfault caused by #2468 when guns are fired #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dumb code I made
scarf005
approved these changes
Mar 31, 2023
scarf005
reviewed
Mar 31, 2023
Co-authored-by: scarf <greenscarf005@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix possible segfault caused by #2468 when guns are fired."
Purpose of change
Fixes #2512
#2468 has an apparent issue due to how I structured an if block. Fix that ASAP.
Basically, if the gun doesn't use ammo, it will still try to check the amount of ammo passed by the ammo item_location, which will lead to a null reference that crashes the game.
Describe the solution
Restructures it so it doesn't route through ammo.get_item()->count() unless the item actually exists.
Describe alternatives you've considered
Testing
Fire A7 laser rifle, it doesn't crash.
Additional context
I'm an idiot and I should've playtested this a lot fucking more.