Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dragging plugged-in grid furniture #2509

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Bugfixes "Disallow dragging all other grid furniture"

Purpose of change

So snezhniylis on the discord discovered an issue with dragging grid furniture, first noticed with space heaters:
image

Aside from whatever causes this, a JSON update for this also makes sense on the basis of all of the grid furniture being stuff that's plugged or wired into the grid, and you would logically want to unplug it before moving it around. Most grid furniture follows this logic already barring some exceptions.

Describe the solution

Set it so that foodco kitchen buddies, fridges, freezers, and space heaters have a required_str of minus one, preventing you from dragging them around.

Describe alternatives you've considered

Digging through the code, trying to find why this dupe happens, focusing on that instead of a quickfix that renders it a non-issue for now and probably screaming at C++ yet again.

Testing

  1. Checked affect file for syntax and lint errors.
  2. Tested dragging around one of the furniture that inherits from another, to confirm that inheriting required strength actually works.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Mar 30, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done is better than perfect.

@scarf005 scarf005 merged commit 2bff3a5 into cataclysmbnteam:upload Mar 31, 2023
@chaosvolt chaosvolt deleted the heaters-are-plugged-in branch March 31, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants