Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show maximum buoyancy on vehicle info #2339

Merged
merged 6 commits into from
Feb 26, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Feb 12, 2023

Summary

SUMMARY: Interface "Show maximum buoyancy"

Purpose of change

Describe the solution

calculate maximum buoyancy using archimedes's law, that is volume * density of water * earth gravity.
display method is identical to #1631 .

Describe alternatives you've considered

  • change water_hull_height as mutable?
  • instead show 'mass left until sinking'? (max buoyancy - total mass)

Testing

boat

screenshots

Cataclysm: Bright Nights - cda4bc75df-dirty_04
Cataclysm: Bright Nights - cda4bc75df-dirty_05
Cataclysm: Bright Nights - cda4bc75df-dirty_06

created a canoe, calculated maximum buoyancy was 2880kg.
the canoe sank at approx. 2890kg.

seaplane

screenshots

Cataclysm: Bright Nights - a286e23cea-dirty_01
Cataclysm: Bright Nights - a286e23cea-dirty_02
Cataclysm: Bright Nights - a286e23cea-dirty_03

created a seaplane, it both shows maximum lift and buoyancy accordingly.

@github-actions github-actions bot added the src changes related to source code. label Feb 12, 2023
@Coolthulhu Coolthulhu self-assigned this Feb 15, 2023
@Coolthulhu Coolthulhu merged commit 79a1a11 into cataclysmbnteam:upload Feb 26, 2023
@scarf005 scarf005 deleted the buoyancy branch February 26, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add maximum float weight on vehicle information panel when boat hulls are connected
2 participants