Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict JSON checks by default #2245

Merged

Conversation

olanti-p
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Enabled strict JSON checks by default"

Purpose of change

These checks are quite useful when it comes to making mods and changing game files, yet not all people know they are a thing, so make them much more noticeable.

Describe the solution

  1. Rename "Report unused JSON fields" into "Strict JSON checks" as the feature has grown in scope
  2. Enable it by default
  3. Change ID of the option so it'll become enabled on existing installations
  4. Simplify code a bit

Describe alternatives you've considered

Enabling them permanently

@github-actions github-actions bot added the src changes related to source code. label Dec 18, 2022
@Coolthulhu Coolthulhu self-assigned this Jan 4, 2023
@Coolthulhu Coolthulhu merged commit fafb61c into cataclysmbnteam:upload Jan 5, 2023
@olanti-p olanti-p deleted the enable-jsonchecks-by-default branch August 17, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants