Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] add enchanted rings back to dragon's lair loot #2103

Conversation

leoCottret
Copy link
Collaborator

@leoCottret leoCottret commented Oct 21, 2022

Summary

SUMMARY: Bugfixes "add enchanted rings back to dragon's lair loot"

Purpose of change

Due to some unknown changes, the dragon's lair didn't use his "treasury" item group for the final room.
It used the item group for the random objects in the lair, before the "treasury" final room.
Since the enchanted rings are in the treasury item group, they never spawned in the lair.

Describe the solution

Fix this problem by using the item group for the treasury.
This is also on par with the current DDA version, but I couldn't find the commit that resolved that, only the commit that introduced the bug.

Testing

  • for testing, you might want to increase the probability that a ring appears, because it seems quite low.
  • then reveal the map, go one tile below ground 0 and search for white "%" signes
    image
  • teleport here and verify that at least one ring spawned

@Coolthulhu Coolthulhu self-assigned this Oct 22, 2022
@Coolthulhu Coolthulhu merged commit 7220072 into cataclysmbnteam:upload Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants