Format configs #1987
Merged
Format configs #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
olanti-p
reviewed
Oct 11, 2022
.clang-tidy
Outdated
Comment on lines
56
to
61
|
|
||
| -modernize-use-nodiscard | ||
| -modernize-concat-nested-namespaces | ||
| -modernize-loop-convert | ||
| -modernize-unary-static-assert | ||
| -readability-redundant-declaration |
There was a problem hiding this comment.
Same issue here, empty line + no commas. Also, useless without c++17. Why not roll changes to this file into the c++17 PR?
There was a problem hiding this comment.
yeah, will remove the commit. Thoght .clang-tidy had to be changed from upload to take effect on workflow run.
Coolthulhu
reviewed
Oct 11, 2022
| [*.json] | ||
| end_of_line = lf | ||
| insert_final_newline = true | ||
| indent_style = space |
There was a problem hiding this comment.
Why remove those? Are they the defaults?
There was a problem hiding this comment.
yes, all of its configs are inherited from [*], so there would be no need for it.
This reverts commit b14365c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Format .clang-tidy and append .editorconfig"
Purpose of change
.editorconfigdoes not have config for markdown and yaml where indent 2 is used.clang-tidy's file extension isyamlyet it's not formatted properlyDescribe the solution
.editorconfig.clang-tidyreadability-identifier-lengthbecause almost every file uses variables with 1~2 length and it's clogging error messages