Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dense retrieval regression test cases + doc update #380

Merged
merged 4 commits into from
Feb 18, 2021
Merged

Dense retrieval regression test cases + doc update #380

merged 4 commits into from
Feb 18, 2021

Conversation

lintool
Copy link
Member

@lintool lintool commented Feb 16, 2021

Truncated regression comparisons to 4 digits, minor documentation tweaks.

Running regressions, not ready for review or merging yet.

@lintool lintool requested a review from MXueguang February 16, 2021 22:57
@lintool lintool marked this pull request as draft February 16, 2021 22:57
MXueguang
MXueguang approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@MXueguang MXueguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lintool lintool marked this pull request as ready for review February 18, 2021 12:28
@lintool
Copy link
Member Author

lintool commented Feb 18, 2021 

python -m unittest discover -s integrations

Ran successfully on orca: Ran 44 tests in 101176.698s ~ 28 hours

@lintool lintool merged commit 8c32a8e into master Feb 18, 2021
@lintool lintool deleted the regression-update branch February 18, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MXueguang MXueguang MXueguang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lintool @MXueguang