Add to onboarding reproduction logs #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndreSlavescu have you tried the instructions here? https://github.com/castorini/pyserini/blob/master/docs/installation.md#pypi-installation-walkthrough If you're on a Mac with an M-series (i.e., ARM) processor, the following recipe should work: |
lintool
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment
Ran in conda environment
with the following command: conda install -c pytorch faiss-cpu=1.7.4 mkl=2021 blas=1.0=mkl
System
Operating System
Development Environment
Hardware
Result
Ran all tests successfully after downgrading to python 3.10.12 and running in a conda env + faiss installation for conda target.
Additional Notes
I tried building for mac with M2 pro 12 core spec, but ultimately failed due to issue with nmslib. I will try to make a fix in the future, but for the time being, as far as I know, the package will not build for m series mac devices without any downgrading to older package versions.
build instruction that will work for Macbook Pro M1 2020 is:
CFLAGS="-mavx -DWARN(a)=(a)" pip install nmslib
I do not recommend building with this however, because this disables some acceleration profiles.
Refer to this issue for more information:
nmslib/nmslib#476