Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduced results - experiments-msmacro-passage #1712

Merged
merged 8 commits into from
Nov 23, 2023

Conversation

Seun-Ajayi
Copy link
Contributor

Everything worked!

System Information:

Operating System: Ubuntu 20.04.6 LTS on GCP
Number of CPUs: 8
Amount of Memory: 32GB
Disk Space: 100GB
Environment Configuration:

Python Version: Python 3.10.13
Java Version:
openjdk 11.0.13 2021-10-19
OpenJDK Runtime Environment JBR-11.0.13.7-1751.21-jcef (build 11.0.13+7-b1751.21)
OpenJDK 64-Bit Server VM JBR-11.0.13.7-1751.21-jcef (build 11.0.13+7-b1751.21, mixed mode)

@lintool
Copy link
Member

lintool commented Nov 13, 2023

Please continue along the onboarding path until you reach the end of the exercises, and then we'll take a look all at once.

@lintool lintool marked this pull request as draft November 13, 2023 23:42
@lintool
Copy link
Member

lintool commented Nov 21, 2023

Why have the queries and qrels been deleted?

+ Results reproduced by [@oscarbelda86](https://github.com/oscarbelda86) on 2023-11-13 (commit [`086e16b`](https://github.com/castorini/pyserini/commit/086e16be28b7dc6022f8582dbd803824dc2c1ad2))+ Results reproduced by [@Seun-Ajayi](https://github.com/Seun-Ajayi) on 2023-11-13 (commit [`086e16b`](https://github.com/castorini/pyserini/commit/086e16be28b7dc6022f8582dbd803824dc2c1ad2))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your entry should be on it's own line...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I want to ask, which experiment am I meant to take next? This information was not indicated in the last exercise I did, the conceptual-framework2

@lintool lintool marked this pull request as ready for review November 23, 2023 15:15
@lintool lintool merged commit 1219cdb into castorini:master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants