Skip to content

Commit

Permalink
Fix flaky mrtydi test on M1 (#1495)
Browse files Browse the repository at this point in the history
  • Loading branch information
lintool authored Apr 11, 2023
1 parent cfd983b commit 1aea2b0
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions scripts/repro_matrix/run_all_mrtydi.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ def print_results(metric, split):
elif name == 'mdpr-tied-pft-msmarco-ft-all.ko' and split == 'train' \
and math.isclose(score, float(expected[metric]), abs_tol=4e-4):
result_str = okish_str
# Flaky test: small difference on Mac Studio (M1)
elif name == 'mdpr-tied-pft-msmarco.th' and split == 'train' \
and math.isclose(score, float(expected[metric]), abs_tol=3e-4):
result_str = okish_str
else:
result_str = fail_str + f' expected {expected[metric]:.4f}'
print(f' {metric:7}: {score:.4f} {result_str}')
Expand Down

0 comments on commit 1aea2b0

Please sign in to comment.