Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index dir option, change evaluate_passage_ranking to be consistent with CovidQA, update index to latest #33

Merged
merged 9 commits into from
May 26, 2020
Merged

Index dir option, change evaluate_passage_ranking to be consistent with CovidQA, update index to latest #33

merged 9 commits into from
May 26, 2020

Conversation

ronakice
Copy link
Member

No description provided.

@ronakice ronakice requested a review from rodrigonogueira4 May 26, 2020 12:36
rodrigonogueira4
rodrigonogueira4 reviewed May 26, 2020
View reviewed changes
Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving this! I added just one comment

@ronakice
Copy link
Member Author

It's done lmk if i can merge!

rodrigonogueira4
rodrigonogueira4 approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ronakice ronakice merged commit add59ba into master May 26, 2020
@ronakice ronakice deleted the index-dir-option branch May 26, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigonogueira4 rodrigonogueira4 rodrigonogueira4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronakice @rodrigonogueira4