Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link for qrel.dev.small.tsv #191

Merged
merged 4 commits into from
May 18, 2021

Conversation

larryli1999
Copy link
Contributor

Update the link to download qrels.dev.small.tsv

@@ -71,7 +71,7 @@ Let's start.
cd ${DATA_DIR}
wget https://storage.googleapis.com/duobert_git/run.bm25.dev.small.tsv
wget https://www.dropbox.com/s/hq6xjhswiz60siu/queries.dev.small.tsv
wget https://www.dropbox.com/s/5t6e2225rt6ikym/qrels.dev.small.tsv
wget https://www.dropbox.com/s/ie27l0mzcjb5fbc/qrels.dev.small.tsv?dl=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ?dl=1?

Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor comment.

@lintool
Copy link
Member

lintool commented May 18, 2021

hey @larryli1999 @ronakice are these the same ones here? https://github.com/castorini/anserini/tree/master/src/main/resources/topics-and-qrels

If so, fetch from there. That's stable.

@larryli1999
Copy link
Contributor Author

I have updated the github links as well as the corresponding file names in the documentation.

@ronakice
Copy link
Member

Okay LGTM after the new edits, merging! Thanks :)

@ronakice ronakice merged commit d50c6b0 into castorini:master May 18, 2021
@larryli1999 larryli1999 deleted the larryli1999-patch-2 branch May 30, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants