Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated readme and evaluation scripts #18

Merged
merged 3 commits into from
Jun 20, 2019
Merged

Updated readme and evaluation scripts #18

merged 3 commits into from
Jun 20, 2019

Conversation

emmileaf
Copy link
Member

  • Fixed typo in readme for baseline results
  • Added call in baseline.sh to create runs directory if it doesn't exist (in cases where we run baseline.sh first, or separately from the other scripts)
  • Updated executable permission for eval.sh, and edited message in 3S part of output

Some small changes, @zeynepakkalyoncu for visibility

zeynepakkalyoncu
zeynepakkalyoncu approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@zeynepakkalyoncu zeynepakkalyoncu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zeynepakkalyoncu zeynepakkalyoncu merged commit e1b19ab into castorini:master Jun 20, 2019
@emmileaf emmileaf deleted the evaluation-patch branch June 27, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeynepakkalyoncu zeynepakkalyoncu zeynepakkalyoncu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmileaf @zeynepakkalyoncu