Clean up of dense inverted indexing code #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2263 +/- ##
============================================
+ Coverage 61.19% 61.67% +0.47%
+ Complexity 1271 1244 -27
============================================
Files 197 196 -1
Lines 11837 11554 -283
Branches 1545 1490 -55
============================================
- Hits 7244 7126 -118
+ Misses 4047 3889 -158
+ Partials 546 539 -7 ☔ View full report in Codecov by Sentry. |
|
@tteofili This is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tteofili I ripped out all the code paths for Glove... not needed anymore...