Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regressions for OpenAI ada2 embeddings on MS MARCO passage #2235

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

lintool
Copy link
Member

@lintool lintool commented Nov 3, 2023

With Lucene 9.8 upgrade, the 1536d embeddings work now!

@lintool lintool marked this pull request as ready for review November 3, 2023 23:59
Copy link
Member

@jasper-xian jasper-xian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lintool lintool merged commit d76bb4c into master Nov 4, 2023
1 check passed
@lintool lintool deleted the openai branch November 4, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants