Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paths for docs, src #2103

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fix paths for docs, src #2103

merged 1 commit into from
Apr 18, 2023

Conversation

ArthurChen189
Copy link
Member

Changed paths from src/main/resources/topics-and-qrels to tools/topics-and-qrels

@ArthurChen189 ArthurChen189 requested a review from lintool April 13, 2023 16:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (467ac5a) 58.93% compared to head (fa463a4) 58.89%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2103      +/-   ##
============================================
- Coverage     58.93%   58.89%   -0.04%     
+ Complexity     1189     1188       -1     
============================================
  Files           194      194              
  Lines         11316    11318       +2     
  Branches       1485     1486       +1     
============================================
- Hits           6669     6666       -3     
- Misses         4166     4170       +4     
- Partials        481      482       +1

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

lintool
lintool requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert the changes in src/main/python back to the original paths? Rationale is that those are mostly one-off scripts that aren't being used anymore... I'd rather they be left alone - we can fix them if we decided to use them again. That way git blame will be (more) accurate.

src/test/java/io/anserini/eval/RelevanceJudgmentsTest.java Show resolved Hide resolved
@ArthurChen189 ArthurChen189 requested a review from lintool April 17, 2023 23:53
@lintool
Copy link
Member

lintool commented Apr 18, 2023

please revert these two files?

@lintool lintool self-requested a review April 18, 2023 10:13
@ArthurChen189 ArthurChen189 merged commit 68c19a2 into castorini:master Apr 18, 2023
aryamancodes pushed a commit to aryamancodes/anserini that referenced this pull request Apr 22, 2023
@ArthurChen189 @aryamancodes
Fix topics-and-qrels path for docs and java files (castorini#2103)
431ae77 
Changed paths from src/main/resources/topics-and-qrels to tools/topics-and-qrels
@ArthurChen189 ArthurChen189 deleted the topic-path-fix branch May 7, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lintool lintool lintool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArthurChen189 @codecov-commenter @lintool