Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beir splade patch #1856

Merged
merged 5 commits into from
Apr 25, 2022
Merged

Beir splade patch #1856

merged 5 commits into from
Apr 25, 2022

Conversation

justram
Copy link
Member

@justram justram commented Apr 25, 2022

  • Add topics, regressions, and tests for splade distill cocodenser medium; collections: cqadupstack subsets, bioasq, trec-news, signal-1m, and robust04
  • Revise collection namings for splade distill cocodenser medium

lintool
lintool approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, but double check beir-v1.0.0-robust04-flat.yaml... looks wrong - should have 528k docs...

src/main/resources/regression/beir-v1.0.0-robust04-flat.yaml Outdated
@@ -8,9 +8,9 @@ generator_class: DefaultLuceneDocumentGenerator
index_threads: 1
index_options: -storePositions -storeDocvectors -storeRaw
index_stats:
documents: 528036
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a bug here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, accidentally changed the old yaml when creating the new ones. I am fixing it.

@justram justram merged commit d4155e2 into castorini:master Apr 25, 2022
@justram justram deleted the beir_splade_patch branch April 25, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lintool lintool lintool approved these changes

@thakur-nandan thakur-nandan Awaiting requested review from thakur-nandan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justram @lintool