Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MS MARCO (V1) doc regressions #1723

Merged
merged 16 commits into from
Jan 8, 2022
Merged

Refactor MS MARCO (V1) doc regressions #1723

merged 16 commits into from
Jan 8, 2022

Conversation

lintool
Copy link
Member

@lintool lintool commented Jan 7, 2022

Closes #1721

@lintool lintool requested review from ronakice and MXueguang January 7, 2022 16:49
@lintool lintool marked this pull request as draft January 7, 2022 16:49
@lintool lintool marked this pull request as ready for review January 7, 2022 18:57
ronakice
ronakice approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lintool lintool merged commit 6fcb896 into master Jan 8, 2022
@lintool lintool deleted the msmarco branch January 8, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronakice ronakice ronakice approved these changes

@MXueguang MXueguang Awaiting requested review from MXueguang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New MS MARCO (V1) doc regressions
2 participants
@lintool @ronakice