Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computes query-doc score for a specific document #1194

Merged
merged 3 commits into from
May 14, 2020
Merged

Computes query-doc score for a specific document #1194

merged 3 commits into from
May 14, 2020

Conversation

lintool
Copy link
Member

@lintool lintool commented May 14, 2020

@lintool lintool requested a review from chriskamphuis May 14, 2020 14:00
chriskamphuis
chriskamphuis approved these changes May 14, 2020
View reviewed changes
Copy link
Collaborator

@chriskamphuis chriskamphuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice very useful feature

@codecov
Copy link

codecov bot commented May 14, 2020 •
edited
Loading

Codecov Report

Merging #1194 into master will increase coverage by 0.06%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1194      +/-   ##
============================================
+ Coverage     48.24%   48.31%   +0.06%     
- Complexity      731      734       +3     
============================================
  Files           147      147              
  Lines          8508     8522      +14     
  Branches       1210     1211       +1     
============================================
+ Hits           4105     4117      +12     
- Misses         4062     4064       +2     
  Partials        341      341
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/anserini/index/IndexReaderUtils.java 50.49% <87.50%> (+3.12%) 26.00 <4.00> (+4.00)
...java/io/anserini/ltr/feature/CountBigramPairs.java 87.01% <0.00%> (-2.60%) 31.00% <0.00%> (-2.00%)
...anserini/ltr/feature/base/PMIFeatureExtractor.java 86.53% <0.00%> (+1.92%) 13.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d48fb4...e19f444. Read the comment docs.

@cmacdonald
Copy link

+1
looks good to me. I mentioned to Jimmy the extension to multiple documents.

@lintool lintool merged commit a65646f into master May 14, 2020
@lintool lintool deleted the compute-qdoc-score branch May 14, 2020 14:37
crystina-z pushed a commit to crystina-z/anserini that referenced this pull request Oct 28, 2022
@lintool
Add to uniCOIL reproduction log; fix minor typos in documentation (ca…
cbb18c7 
…storini#1194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskamphuis chriskamphuis chriskamphuis approved these changes

@cmacdonald cmacdonald cmacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lintool @cmacdonald @chriskamphuis