feat: add get_all_roles_by_domain api #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nekotoxin please review |
leeqvip
suggested changes
Aug 31, 2023
| for policy in policies: | ||
| if policy[len(policy) - 1] == domain: | ||
| role = policy[len(policy) - 2] | ||
| if role not in roles: |
There was a problem hiding this comment.
Use set+sort or dict key to list to improve performance.
leeqvip
approved these changes
Aug 31, 2023
| if role not in roles: | ||
| roles.add(role) | ||
|
|
||
| return list(roles) |
There was a problem hiding this comment.
@BustDot The set is unordered. If the order is not required to get all roles here, then I think it is ok to do so.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
# [1.26.0](v1.25.0...v1.26.0) (2023-08-31) ### Features * add get_all_roles_by_domain api ([#316](#316)) ([22507ca](22507ca))
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to: casbin/casbin#1190