Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the predefined member #325

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

premac
Copy link
Contributor

@premac premac commented Oct 5, 2023

SimpleEval class declares a class variable ast_parsed_value mean to store the parsed value. However, it is not used and instead, another variable is created in the constructor.

@casbin-bot
Copy link
Member

@Nekotoxin please review

@casbin-bot casbin-bot requested a review from Nekotoxin October 5, 2023 11:05
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@leeqvip leeqvip changed the title use the predefined member fix: use the predefined member Oct 6, 2023
@leeqvip leeqvip merged commit 4f191f0 into casbin:master Oct 6, 2023
12 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 6, 2023
## [1.31.2](v1.31.1...v1.31.2) (2023-10-06)

### Bug Fixes

* use pre defined member ([#325](#325)) ([4f191f0](4f191f0))
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

🎉 This PR is included in version 1.31.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants