Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polish import grammar and remove some useless package #282

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

Undertone0809
Copy link
Contributor

@casbin-bot
Copy link
Member

@Nekotoxin please review

@casbin-bot casbin-bot requested a review from Nekotoxin December 4, 2022 10:19
@hsluoyz
Copy link
Member

hsluoyz commented Dec 4, 2022

@Undertone0809 fix all checks:

image

@Undertone0809
Copy link
Contributor Author

@hsluoyz build problem has been solved. I want to know why single blank line cannot pass the build?
image

About Coveralls, maybe I need to study more and new PR to write unit test to improve coverage.

@hsluoyz hsluoyz merged commit be53e0b into casbin:master Dec 5, 2022
github-actions bot pushed a commit that referenced this pull request Dec 5, 2022
## [1.17.5](v1.17.4...v1.17.5) (2022-12-05)

### Bug Fixes

* polish import grammar and remove some useless package ([#282](#282)) ([be53e0b](be53e0b))
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

🎉 This PR is included in version 1.17.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants