fix: different behavior of glob_match from other casbin #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ffyuanda @Zxilly @elfisworking please review |
|
@Nekotoxin plz squash commits:
|
|
@Nekotoxin Although it passes the unit test cases, it does not fully implement globbing patterns，like: |
ok. I will do it and add more testcases. |
have updated, added more test and compared the bahavior with glob match in golang. plz review |
# Conflicts: # tests/util/test_builtin_operators.py
leeqvip
suggested changes
Apr 29, 2022
leeqvip
approved these changes
Apr 30, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Apr 30, 2022
## [1.16.3](v1.16.2...v1.16.3) (2022-04-30) ### Bug Fixes * different behavior of glob_match from other casbin ([#254](#254)) ([49b6a04](49b6a04))
|
🎉 This PR is included in version 1.16.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #148
Reimplement the glob_match