remove clones and string allocs, use macro for model retreval #87
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 79.45% 80.89% +1.44%
==========================================
Files 21 21
Lines 2745 2712 -33
==========================================
+ Hits 2181 2194 +13
+ Misses 564 518 -46
Continue to review full report at Codecov.
|
|
lgtm. It seems much more clear when we have only one commit for specific things. I also think it may cause some confusion if we return However we cannot return Line 52 in 301420c Why I did this is because: If we do |
|
|
||
| let file = FileAdapter::new("examples/basic_policy.csv"); | ||
| let mem = MemoryAdapter::default(); | ||
| let mut e = Enforcer::new(Box::new(m), Box::new(file)).await.unwrap(); |
There was a problem hiding this comment.
here We don't need Box anymore
In the
FileAdapterwhen the method is unimplemented likeadd_policyinstead of returningOk(true)would false be a better signal or evenpanic!("this is not available for 'FileAdapter')maybe?